on Python3, use the new unittest.mock from standard library #48
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Considering that it makes little sense to support anything before Python 3.8, or 3.6 to be even more conservative, maybe we can even drop the |
|
Yes. Common sense is not the same thing for everyone.
Le mar. 11 juin 2024 à 15:03, Daniele Varrazzo ***@***.***> a
écrit :
… Considering that it makes little sense to support anything before Python
3.8, or 3.6 to be even more conservative, maybe we can even drop the try?
—
Reply to this email directly, view it on GitHub
<#48 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AB47WUC74NSTD4DBS5O4CVLZG3YRHAVCNFSM6AAAAABJDTYLJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRQG4YTEOBQGM>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
Elsewhere in this project it is implicitly stated that 2.7 is still
supported.
Programming Language :: Python :: 2
python_requires='>=2.7,!=3.0.*,!=3.1.*,!=3.2.*,!=3.3.*',
Le mar. 11 juin 2024 à 15:25, Alexandre Detiste ***@***.***>
a écrit :
… Yes. Common sense is not the same thing for everyone.
Le mar. 11 juin 2024 à 15:03, Daniele Varrazzo ***@***.***>
a écrit :
> Considering that it makes little sense to support anything before Python
> 3.8, or 3.6 to be even more conservative, maybe we can even drop the try?
>
> —
> Reply to this email directly, view it on GitHub
> <#48 (comment)>, or
> unsubscribe
> <https://github.com/notifications/unsubscribe-auth/AB47WUC74NSTD4DBS5O4CVLZG3YRHAVCNFSM6AAAAABJDTYLJ2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMZDCNRQG4YTEOBQGM>
> .
> You are receiving this because you authored the thread.Message ID:
> ***@***.***>
>
|
|
We can most definitely drop support for Python 2.7. |
|
And then remove six too... |
|
This is ready |
|
Hello, thank you I see that this project still uses travis for tests. Are you able to migrate the CI to Github Actions? |
|
Me ? I think project admin can push anything to this branch but I don't have the skills fir this one task. |
|
Ok, thank you. At the moment, automated tests don't run on this project and I am swamped with other work, therefore I cannot test this MR right now. I appreciate your work, I will merge your MR to master as I get around doing it. Thank you very much. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
https://github.com/testing-cabal/mock
mock is now part of the Python standard library, available as unittest.mock in Python 3.3 onwards.