Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Uploading files for new integration tests #10

Merged
merged 5 commits into from
May 21, 2024
Merged

Conversation

kylacochrane
Copy link
Contributor

This PR adds additional integration tests and files pertaining to:

  1. Filtering the query sample cluster addresses for the nf-iridanext plugin
  2. Ensuring query samples are removed from the pipeline if meta.id ≠ JSON Key
  3. Ensuring pipeline is halted if reference sample meta.id ≠ JSON Key

Copy link

github-actions bot commented May 16, 2024

nf-core lint overall result: Passed ✅ ⚠️

Posted for pipeline commit 7feaee8

+| ✅ 149 tests passed       |+
#| ❔  22 tests were ignored |#
!| ❗  15 tests had warnings |!

❗ Test warnings:

  • schema_lint - Schema $id should be https://raw.githubusercontent.com/phac-nml/gasnomenclature/master/nextflow_schema.json
    Found https://raw.githubusercontent.com/phac-nml/gasnomenclature/main/nextflow_schema.json
  • schema_description - No description provided in schema for parameter: gm_thresholds
  • schema_description - No description provided in schema for parameter: gm_delimiter
  • schema_description - No description provided in schema for parameter: ref_clusters
  • schema_description - No description provided in schema for parameter: pd_outfmt
  • schema_description - No description provided in schema for parameter: pd_distm
  • schema_description - No description provided in schema for parameter: pd_missing_threshold
  • schema_description - No description provided in schema for parameter: pd_sample_quality_threshold
  • schema_description - No description provided in schema for parameter: pd_match_threshold
  • schema_description - No description provided in schema for parameter: pd_file_type
  • schema_description - No description provided in schema for parameter: pd_mapping_file
  • schema_description - No description provided in schema for parameter: pd_force
  • schema_description - No description provided in schema for parameter: pd_skip
  • schema_description - No description provided in schema for parameter: pd_columns
  • schema_description - No description provided in schema for parameter: pd_count_missing

❔ Tests ignored:

  • files_exist - File is ignored: assets/nf-core-gasnomenclature_logo_light.png
  • files_exist - File is ignored: docs/images/nf-core-gasnomenclature_logo_dark.png
  • files_exist - File is ignored: docs/images/nf-core-gasnomenclature_logo_light.png
  • files_exist - File is ignored: .github/workflows/awstest.yml
  • files_exist - File is ignored: .github/workflows/awsfulltest.yml
  • nextflow_config - Config variable ignored: manifest.name
  • nextflow_config - Config variable ignored: manifest.homePage
  • files_unchanged - File ignored due to lint config: LICENSE or LICENSE.md or LICENCE or LICENCE.md
  • files_unchanged - File ignored due to lint config: .github/CONTRIBUTING.md
  • files_unchanged - File ignored due to lint config: .github/ISSUE_TEMPLATE/bug_report.yml
  • files_unchanged - File ignored due to lint config: .github/PULL_REQUEST_TEMPLATE.md
  • files_unchanged - File ignored due to lint config: .github/workflows/branch.yml
  • files_unchanged - File ignored due to lint config: assets/email_template.html
  • files_unchanged - File ignored due to lint config: assets/email_template.txt
  • files_unchanged - File ignored due to lint config: assets/sendmail_template.txt
  • files_unchanged - File does not exist: assets/nf-core-gasnomenclature_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-gasnomenclature_logo_light.png
  • files_unchanged - File does not exist: docs/images/nf-core-gasnomenclature_logo_dark.png
  • files_unchanged - File ignored due to lint config: docs/README.md
  • actions_awstest - 'awstest.yml' workflow not found: /home/runner/work/gasnomenclature/gasnomenclature/.github/workflows/awstest.yml
  • actions_awsfulltest - actions_awsfulltest
  • pipeline_name_conventions - pipeline_name_conventions

✅ Tests passed:

Run details

  • nf-core/tools version 2.14.1
  • Run at 2024-05-17 20:57:38

@kylacochrane kylacochrane marked this pull request as ready for review May 16, 2024 18:21
@kylacochrane kylacochrane requested a review from apetkau May 16, 2024 18:22
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great Kyla. Thanks so much. Just one comment 😄

tests/pipelines/main.nf.test Show resolved Hide resolved
Copy link
Member

@apetkau apetkau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great. Thanks so much 😄

@kylacochrane kylacochrane merged commit 7f77c9d into input_check May 21, 2024
4 checks passed
@kylacochrane kylacochrane deleted the add_tests branch May 27, 2024 17:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants