Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

read only mode #82

Merged
merged 14 commits into from
Aug 26, 2020
Merged

read only mode #82

merged 14 commits into from
Aug 26, 2020

Conversation

JeffreyThiessen
Copy link
Member

@JeffreyThiessen JeffreyThiessen commented Jun 15, 2020

Description of changes

Added a readonly mode, can be set with config file, --readonly / -r option on command line, and a checkbox on the gui to upload in read-only mode.
In read-only no status file or log file will be written to sequencing run directory.

Related issue

Fixes #24
Fixes #58

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • CHANGELOG.md updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • User documentation updated for UI or technical changes.

@JeffreyThiessen JeffreyThiessen changed the title reimplement read only mode [WIP] reimplement read only mode Jun 15, 2020
@JeffreyThiessen JeffreyThiessen changed the title [WIP] reimplement read only mode reimplement read only mode Aug 24, 2020
@JeffreyThiessen JeffreyThiessen changed the title reimplement read only mode read only mode Aug 24, 2020
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great and looks good. Just one comment for now

@deepsidhu85 deepsidhu85 merged commit c191ca3 into development Aug 26, 2020
@JeffreyThiessen JeffreyThiessen deleted the read_only_mode_2 branch February 22, 2021 20:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Gui crashes when trying to upload from a read only directory Handle Read-Only Directories
2 participants