Skip to content

Commit

Permalink
Merge pull request #1479 from phac-nml/hotfix-associated-and-linelist
Browse files Browse the repository at this point in the history
HOTFIX: Associated project dropdown and Linelist column order
  • Loading branch information
ericenns authored Mar 21, 2023
2 parents 661ed89 + a36cf2b commit 0db2d74
Show file tree
Hide file tree
Showing 7 changed files with 16 additions and 5 deletions.
7 changes: 6 additions & 1 deletion CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,10 @@

# Changelog

## [23.01.1] - 2023/03/21
* [UI]: Fixed issue where template order was not applied when applying a linelist template. See [PR 1479](https://github.com/phac-nml/irida/pull/1479)
* [UI]: Added select all to associated projects filter on project > samples page. See [PR 1479](https://github.com/phac-nml/irida/pull/1479)

## [23.01] - 2023/02/28
* [UI/Developer]: Updated `react-router` to the version 6.4.3. See[PR 1405](https://github.com/phac-nml/irida/pull/1405)
* [Developer] Updated developer setup documentation, ignore java_pid\*.hprof files, and added quality of life file `gradle.properties`. See [PR 1415](https://github.com/phac-nml/irida/pull/1415).
Expand Down Expand Up @@ -176,8 +180,9 @@

## [...previous](https://github.com/phac-nml/irida/blob/21.09.2/CHANGELOG.md)

[Unreleased]: https://github.com/phac-nml/irida/compare/23.01...HEAD
[Unreleased]: https://github.com/phac-nml/irida/compare/23.01.1...HEAD

[23.01.1]: https://github.com/phac-nml/irida/compare/23.01...23.01.1
[23.01]: https://github.com/phac-nml/irida/compare/22.09.7...23.01
[22.09.7]: https://github.com/phac-nml/irida/compare/22.09.6...22.09.7
[22.09.6]: https://github.com/phac-nml/irida/compare/22.09.5...22.09.6
Expand Down
2 changes: 1 addition & 1 deletion build.gradle.kts
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ plugins {
}

group = "ca.corefacility.bioinformatics"
version = "23.01"
version = "23.01.1"
description = "irida"

java {
Expand Down
Binary file modified doc/user/user/samples/images/associated-projects-filter.gif
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,10 @@ export class TableComponent extends React.Component {
/*
Combine back the sample name plus the new ordered state for the table.
*/
this.columnApi.applyColumnState({ state: [...defaults, ...final] });
this.columnApi.applyColumnState({
state: [...defaults, ...final],
applyOrder: true,
});
};

/*
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -292,6 +292,7 @@ export function SamplesTable() {
return <ProjectTag project={row.project} />;
},
filters: associatedProjects,
filterMode: "tree",
},
{
title: i18n("SamplesTable.Column.collectedBy"),
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -94,6 +94,7 @@ public static void startWebDriver() {
}

options.addArguments("--window-size=1920,1080");
options.addArguments("--remote-allow-origins=*");

// Set up default download directory
if (!DOWNLOAD_DIRECTORY.exists()) {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -400,15 +400,16 @@ public void toggleAssociatedProject(String projectName) {
int prevTotal = getTableSummary().getTotal();
projectsFilterToggle.click();
WebElement selection = driver.findElement(
By.xpath("//li[@class='ant-dropdown-menu-item' and span='" + projectName + "']"));
By.xpath("//div[@class='ant-tree-list-holder-inner']//span[@title='" + projectName + "']"));
selection.click();
driver.findElement(By.xpath("//button[@type='button' and span='OK']")).click();
waitForTableToUpdate(prevTotal);
}

public void removeAssociatedProject(String projectName) {
projectsFilterToggle.click();
WebElement selection = driver.findElement(By.xpath("//li/span/span[text()='" + projectName + "']"));
WebElement selection = driver.findElement(
By.xpath("//div[@class='ant-tree-list-holder-inner']//span[@title='" + projectName + "']"));
selection.click();
driver.findElement(By.xpath("//button[@type='button' and span='OK']")).click();
waitForTime(200);
Expand Down

0 comments on commit 0db2d74

Please sign in to comment.