Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Metadata uploader batch endpoints #1408

Merged
merged 60 commits into from
Jan 10, 2023

Conversation

ksierks
Copy link
Contributor

@ksierks ksierks commented Nov 7, 2022

Description of changes

  • updated createSamplesInProject & updateSamplesInProject in ProjectSamplesAjaxController.java to take more than one sample
  • added a unique database constraint to the label column in the metadata_field table

Related issue

#1400

Checklist

Things for the developer to confirm they've done before the PR should be accepted:

  • [ ] CHANGELOG.md (and UPGRADING.md if necessary) updated with information for new change.
  • Tests added (or description of how to test) for any new features.
  • User documentation updated for UI or technical changes.

@ksierks ksierks marked this pull request as ready for review December 1, 2022 21:00
Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One thing to start. It's a little bigger so it's a part of it's own review. If you have any questions let me know!

Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few more small things

Copy link
Contributor

@deepsidhu85 deepsidhu85 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A few small changes to the urls

Copy link
Member

@ericenns ericenns left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall this is starting to look good, just some comments on the chunk handling.

@ksierks ksierks requested a review from joshsadam January 4, 2023 17:19
Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So I have been slowly going through your code today and I think I found a slightly major performance issue with the UI revolving around you component SampleMetadataImportWizard. The problem with it is that the way you structured it, every time you load in a different component (e.g. SampleMetadataImportReview) the entire UI needs to be redrawn, which really decreases the performance of the page. This can definitely be cleane up after this PR and should really result in any huge code changes, we can talk about it after this PR. These are a few of the things I do need you to look at. Also, please look anywhere that you have used any any a TypeScript type, try to see if you can possibly type it, and if it cannot be, look into unknown and see if that addresses it. I think in you array-utilities this might work since you are passing in arbitraty arrays.

@ksierks ksierks requested a review from joshsadam January 6, 2023 19:08
Copy link
Contributor

@joshsadam joshsadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all those changes

@ericenns ericenns merged commit 32b31f7 into metadata-uploader-base Jan 10, 2023
@ericenns ericenns deleted the metadata-uploader-batch-endpoints branch January 10, 2023 20:24
@ksierks ksierks mentioned this pull request Jan 13, 2023
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Metadata Uploader - Storing duplicate metadata fields with the same label
4 participants