Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

T16467 column 0 to array #16468

Merged
merged 4 commits into from
Nov 23, 2023
Merged

T16467 column 0 to array #16468

merged 4 commits into from
Nov 23, 2023

Conversation

niden
Copy link
Member

@niden niden commented Nov 23, 2023

Hello!

In raising this pull request, I confirm the following:

  • I have read and understood the Contributing Guidelines
  • I have checked that another pull request for this purpose does not exist
  • I wrote some tests for this PR
  • I have updated the relevant CHANGELOG
  • I have created a PR for the documentation about this change

Fixed Phalcon\Mvc\Model\ResultsetSimple::toArray to ignore numeric indexes in case results come as not fetch_assoc

Thanks

@niden niden added bug A bug report status: medium Medium 5.0 The issues we want to solve in the 5.0 release labels Nov 23, 2023
@niden niden requested a review from Jeckerson November 23, 2023 18:12
@niden niden self-assigned this Nov 23, 2023
@niden niden merged commit 20cf90f into phalcon:5.0.x Nov 23, 2023
38 checks passed
@niden niden deleted the T16467-column-0-to-array branch November 23, 2023 20:31
@apoca
Copy link

apoca commented Nov 24, 2023

I'm sorry I was a little confused... Where was this fix? in which version?

@niden
Copy link
Member Author

niden commented Nov 24, 2023

@apoca It is in v5. It will be available with the next release which should come out in a few days.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
5.0 The issues we want to solve in the 5.0 release bug A bug report status: medium Medium
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG]: Column '0' is not part of the column map. After iterating for the second time in a Resultset
3 participants