Skip to content

Commit

Permalink
Merge pull request #142 from phalcon/#141-empty-folder-no-throw
Browse files Browse the repository at this point in the history
#141 - Change `RuntimeException` throw to output warning message
  • Loading branch information
Jeckerson authored May 3, 2023
2 parents 68281b6 + 6058786 commit 69c1ea9
Show file tree
Hide file tree
Showing 2 changed files with 3 additions and 2 deletions.
2 changes: 1 addition & 1 deletion src/Db/FieldDefinition.php
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ public function isChangedName(FieldDefinition $comparingFieldDefinition): bool
public function isChangedData(FieldDefinition $comparingFieldDefinition): bool
{
$paramsToCheck = get_class_methods(ColumnInterface::class);
unset($paramsToCheck['getName']);
//unset($paramsToCheck['getName']); // TODO: Validate if this even needed.

$comparingFieldColumn = $comparingFieldDefinition->getColumn();
foreach ($paramsToCheck as $method) {
Expand Down
3 changes: 2 additions & 1 deletion src/Migrations.php
Original file line number Diff line number Diff line change
Expand Up @@ -270,7 +270,8 @@ public static function run(array $options)
join(PHP_EOL, $migrationsDirList) :
$migrationsDirList;

throw new RuntimeException('Migrations were not found at:' . PHP_EOL . PHP_EOL . $migrationsPath);
echo Color::error('Migrations were not found at:' . $migrationsPath, 'Warning: ');
return;
}

// Set default final version
Expand Down

0 comments on commit 69c1ea9

Please sign in to comment.