[When] Return inside of when statement produces counter-intuitive results

[rsetaluri]

Code like

def my_mux(x, y, s):
    with m.when(~s):
        return x
    with m.otherwise():
        return y

produces counter-intuitive results.

---

We know per the spec that this is acts as expected, but it might be un-expected for the designer. Ideally, we would like to detect such code (and perhaps other similar cases) and raise a warning or error.

[leonardt]

The problem here is that the return control flow exits the code "prematurely" (w.r.t. the designer's desire). I'm not sure we can use the context manager cleanup pattern here to detect this undesired behavior, so I think the only mechanism here would be a linter.