Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add write-manifest.yaml #767

Merged
merged 8 commits into from
May 3, 2024
Merged

Add write-manifest.yaml #767

merged 8 commits into from
May 3, 2024

Conversation

jthompson-arcus
Copy link
Collaborator

No description provided.

@jthompson-arcus jthompson-arcus changed the base branch from master to dev April 24, 2024 14:56
@jthompson-arcus
Copy link
Collaborator Author

@aclark02-arcus check it out. I originally opened this PR on master so that the GHA would trigger. If you look at the yaml you will notice that I had to pull in the most recent version of rsconnect for the build to work. When we update R and the PPM repo date, we should be able to pull from our snapshot.

Obviously, the first time it is run it will cause the most line changes, but check it out and let me know what you think.

@aclark02-arcus
Copy link
Collaborator

Looks good!

@jthompson-arcus jthompson-arcus changed the base branch from dev to master April 30, 2024 19:02
jthompson-arcus and others added 3 commits April 30, 2024 15:07
Merge branch 'jt-gha_for_manifest' of arcus:pharmaR/riskassessment into jt-gha_for_manifest

# Conflicts:
#	manifest.json
@jthompson-arcus jthompson-arcus changed the base branch from master to dev April 30, 2024 19:22
@jthompson-arcus jthompson-arcus changed the base branch from dev to master April 30, 2024 19:26
@jthompson-arcus jthompson-arcus changed the base branch from master to dev April 30, 2024 19:37
@jthompson-arcus
Copy link
Collaborator Author

I want to point out that if you look at 1a8bf23, you will see that despite the manifest being rebuilt, there is very few line changes for the manifest.json file. The changes are a result of updated a line in the file. This is showing the desired behavior or this PR, where the manifest is being built in a more standardized way.

@jthompson-arcus jthompson-arcus marked this pull request as ready for review May 1, 2024 15:09
Copy link
Collaborator

@aclark02-arcus aclark02-arcus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Outstanding!

@aclark02-arcus aclark02-arcus merged commit 4fa6e61 into dev May 3, 2024
@jthompson-arcus jthompson-arcus deleted the jt-gha_for_manifest branch May 7, 2024 14:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants