Skip to content

Commit

Permalink
Merge branch 'enhancement/nca-parameter-input' of https://github.com/…
Browse files Browse the repository at this point in the history
…pharmaverse/aNCA into enhancement/nca-parameter-input
  • Loading branch information
Gero1999 committed Feb 5, 2025
2 parents a9cc6e9 + 7b12d19 commit cf26fb1
Show file tree
Hide file tree
Showing 6 changed files with 67 additions and 19 deletions.
1 change: 1 addition & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
Original file line number Diff line number Diff line change
Expand Up @@ -19,6 +19,7 @@ How to test features not covered by unit tests.
- [ ] Code passes all unit tests
- [ ] New logic covered by unit tests
- [ ] New logic is documented
- [ ] Package version is incremented

## Notes to reviewer

Expand Down
47 changes: 47 additions & 0 deletions .github/workflows/pkgdown.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,47 @@
# Workflow derived from https://github.com/r-lib/actions/tree/v2/examples
on:
push:
branches: main
pull_request:
branches: main
workflow_dispatch:

name: Deploy website

permissions: read-all

jobs:
pkgdown:
runs-on: ubuntu-latest
# Only restrict concurrency for non-PR jobs
concurrency:
group: pkgdown-${{ github.event_name != 'pull_request' || github.run_id }}
env:
GITHUB_PAT: ${{ secrets.GITHUB_TOKEN }}
permissions:
contents: write
steps:
- uses: actions/checkout@v4

- uses: r-lib/actions/setup-pandoc@v2

- uses: r-lib/actions/setup-r@v2
with:
use-public-rspm: true

- uses: r-lib/actions/setup-r-dependencies@v2
with:
extra-packages: any::pkgdown, local::.
needs: website

- name: Build site
run: pkgdown::build_site_github_pages(new_process = FALSE, install = FALSE, dest_dir = "page")
shell: Rscript {0}

- name: Deploy to GitHub pages 🚀
if: github.event_name != 'pull_request'
uses: JamesIves/[email protected]
with:
clean: false
branch: gh-pages
folder: page
12 changes: 11 additions & 1 deletion CONTRIBUTING.md
Original file line number Diff line number Diff line change
Expand Up @@ -60,14 +60,24 @@ This part is here as a reminder to perform basic tasks and checks before the cod
- Code passes all unit tests
- New logic covered is by unit tests
- New logic is documented
- Package version is bumped

The above rules will help keep our work organized, as well as allow for quick information flow between related issues, branches and pull requests.

#### Notes to reviewer
If there is anything that the reviewer should know before tackling the pull request, please provide it here. This could include things like pointing to specific parts of the code that require special attention, explaining decisions behind unusual implementations or providing logic behind changing the scope of the task.

### Bumping package version
Package versioning must use the semantic versioning schema, with developement extension: **X.Y.Z.9NNN**

#### Developement version
In each PR that introduces changes to the code, dependencies or the function documentation, it is required that the developement package version is incremented by 1 (this is the .9NNN number, the last part of the versioning schema). As the current feature branch might be outdated, before merging please cross-check with the **main** branch that the version you are submitting is correct.

#### Semantic versioning
The versioning schema for major / minor / patch releases must adhere to [semantic versioning](https://semver.org/) guidelines.

## Code review
Each pull request must be accepted by at least one reviewer before it can be merged to the main branch.
Each pull request must be accepted by at least two reviewers before it can be merged to the main branch.

#### For reviewee
When the change is done, pull request is open and the description is filled, please move your issue from **In Progress** to **Needs review** status, so it can be picked up by a reviewer. From this point it is up to the contributor and the person validating the change to work out any kinks and lead to merging the changes.
Expand Down
3 changes: 2 additions & 1 deletion DESCRIPTION
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
Package: aNCA
Title: (Pre-)Clinical NCA in a Dynamic Shiny App
Version: 0.0.0.9001
Version: 0.0.0.9002
Authors@R: c(
person("Ercan", "Suekuer", , "[email protected]", role = c("aut", "cre"),
comment = c(ORCID = "0009-0001-1626-1526")),
Expand Down Expand Up @@ -75,3 +75,4 @@ Suggests:
testthat (>= 3.0.0)
Config/testthat/edition: 3
Language: en-US
URL: https://pharmaverse.github.io/aNCA/
3 changes: 3 additions & 0 deletions _pkgdown.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
template:
bootstrap: 5
url: "https://pharmaverse.github.io/aNCA/"
20 changes: 3 additions & 17 deletions inst/shiny/global.R
Original file line number Diff line number Diff line change
@@ -1,18 +1,4 @@
source("modules/tab_data.R")
#Load labels
LABELS <- read.csv(system.file("shiny/data/adnca_labels.csv", package = "aNCA"))

source("modules/nca_settings.R")

source("modules/slope_selector.R")

source("modules/units_table.R")
lapply(list.files("modules", pattern = "\\.R$", full.names = TRUE), source)
lapply(list.files("functions", pattern = "\\.R$", full.names = TRUE), source)

source("functions/partial_auc_input.R")

source("modules/tlg_plot.R")

source("modules/tab_visuals.R")

source("functions/mapping_selectize_inputs.R")
source("functions/generate_col_defs.R")
LABELS <- read.csv(system.file("shiny/data/adnca_labels.csv", package = "aNCA"))

0 comments on commit cf26fb1

Please sign in to comment.