Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor/modularize parameter datasets #188

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Refactor/modularize parameter datasets #188

wants to merge 4 commits into from

Conversation

m-kolomanski
Copy link
Collaborator

@m-kolomanski m-kolomanski commented Jan 31, 2025 •
edited
Loading

Issue

Addresses #144, #63

Description

  • Migrates Parameter Datasets to separate shiny module.
  • Changes the UI to bslib

How to test

Run the application, check if everything runs smoothly.

Contributor checklist

  • Code passes lintr checks
  • Package version is incremented

@m-kolomanski m-kolomanski marked this pull request as ready for review January 31, 2025 12:09
Gotfrid
Gotfrid approved these changes Jan 31, 2025
View reviewed changes
Copy link
Collaborator

@Gotfrid Gotfrid left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, please add blank lines to the files.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gotfrid Gotfrid Gotfrid approved these changes

@js3110 js3110 Awaiting requested review from js3110

@Gero1999 Gero1999 Awaiting requested review from Gero1999

At least 2 approving reviews are required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@m-kolomanski @Gotfrid