Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove renv and use cran latest #176

Merged
merged 48 commits into from
Jan 16, 2024
Merged

Remove renv and use cran latest #176

merged 48 commits into from
Jan 16, 2024

Conversation

dgrassellyb
Copy link
Collaborator

@dgrassellyb dgrassellyb commented Dec 8, 2023 •
edited
Loading

  • update docker images (build devel, latest and oldrel (4.3) from DESCRIPTION file + using latest CRAN repo) - note that there is a dependency with Rework r repos insightsengineering/r-image-creator#18
  • update r-cmd checks matrix to use latest CRAN
  • add workflow to check latest release on rocker/rstudio dockerhub tags
  • upload docker images dependencies on admiralci release
  • update other workflows using admiralci-latest
  • setup script to install local dependencies (tested on a base image rocker/rstudio:latest)

@dgrassellyb dgrassellyb marked this pull request as ready for review December 8, 2023 16:27
@dgrassellyb dgrassellyb requested a review from cicdguy as a code owner December 8, 2023 16:27
@dgrassellyb dgrassellyb marked this pull request as draft December 8, 2023 16:27
@dgrassellyb
Copy link
Collaborator Author

(Just need to rename latest image to release before changing PR from draft to ready)

bms63
bms63 reviewed Dec 8, 2023
View reviewed changes
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we implement this after 1.0 is sent to CRAN. We are very close (Monday or Tuesday I believe)

@cicdguy
Copy link
Collaborator

cicdguy commented Dec 8, 2023

Can we implement this after 1.0 is sent to CRAN. We are very close (Monday or Tuesday I believe)

Yes, let's hold off on this until 1.0 is on CRAN.

@dgrassellyb dgrassellyb mentioned this pull request Jan 2, 2024
Closed
@dgrassellyb dgrassellyb marked this pull request as ready for review January 3, 2024 08:44
@dgrassellyb
Copy link
Collaborator Author

Could we proceed merging this one @cicdguy / @bms63 ?

bms63
bms63 approved these changes Jan 16, 2024
View reviewed changes
Copy link
Collaborator

@bms63 bms63 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's see what happens!!

@bms63 bms63 merged commit a25b02b into main Jan 16, 2024
5 checks passed
@bms63 bms63 deleted the use_cran_latest branch January 16, 2024 13:11
@dgrassellyb
Copy link
Collaborator Author

dgrassellyb commented Jan 17, 2024 •
edited
Loading

Let's see what happens!!

(you can find here latest checks logs - (from workflow dispatch event with also devel chek) https://github.com/pharmaverse/admiral/actions/runs/7553548756/job/20564562353 - and actually it worked also for devel ! 🕺)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bms63 bms63 bms63 approved these changes

@cicdguy cicdguy Awaiting requested review from cicdguy cicdguy is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgrassellyb @cicdguy @bms63 @pharmaverse-bot