Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

delete existing release artifacts #182

Merged
merged 5 commits into from
Feb 2, 2024
Merged

delete existing release artifacts #182

merged 5 commits into from
Feb 2, 2024

Conversation

dgrassellyb
Copy link
Collaborator

@cicdguy : I add a step here to delete existing artifacts in admiralci release (see issue #181 ) - but not sure.. for me it should be temporary fix, because the issue is more coming from downstream upload-release-action where option overwrite: true is not working (as I mentioned on the issue #181)

@dgrassellyb dgrassellyb requested a review from cicdguy as a code owner January 23, 2024 15:40
@cicdguy
Copy link
Collaborator

cicdguy commented Jan 23, 2024

Try using this action as a check to see if the release exists and then conditionally try uploading the assets.

See example here

@dgrassellyb
Copy link
Collaborator Author

@cicdguy : ready to be merged ! I applied the solution I mentioned earlier (delete existing artifacts) because overwrite: true does not work.
https://github.com/pharmaverse/admiralci/actions/runs/7753906361

Copy link
Collaborator

@cicdguy cicdguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thanks @dgrassellyb

@cicdguy cicdguy merged commit aab9fc2 into main Feb 2, 2024
5 checks passed
@cicdguy cicdguy deleted the fix_docker_im_artifacts branch February 2, 2024 12:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants