Fix package selection in the new Finder #1128
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes pharo-spec#1126 Now we can select a package we did not select originaly I also did a refeactoring so that all of the environment search behavior is in StFinderEnvironmentBar and not in StFinderPresenter. This should make the code simpler and not mix the management of the environment in two classes
jecisc
commented
May 19, 2025
Comment on lines
+68
to
+70
| | globalEnv | | ||
| globalEnv := RBBrowserEnvironment new. | ||
| ^ (globalEnv forPackages: globalEnv packages) packages collect: [ :package | package name ] as: OrderedCollection |
There was a problem hiding this comment.
This is the main change of the PR. Most of the other changes are to move the behavior of environment selection in StFinderEnvironmentBar instead of StFinderPresenter.
Before we looked in a filtered environment, now we look in an environment having all the packages of the image
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1126
Now we can select a package we did not select originaly
I also did a refeactoring so that all of the environment search behavior is in StFinderEnvironmentBar and not in StFinderPresenter. This should make the code simpler and not mix the management of the environment in two classes