Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fixes right click on lists and... #1708

Open
wants to merge 29 commits into
base: Pharo13
Choose a base branch
from
Open

fixes right click on lists and... #1708

wants to merge 29 commits into from

Conversation

estebanlm
Copy link
Member

  • SpPopoverPresenter now send open/close announcements
  • SpTabLayout now have selectIndex api
  • SpMenuButtonPresenter now have fillWith: to add actions

Ayachi Nour and others added 24 commits December 20, 2024 16:44
A test that checks whether the elements stay within the window's dime…
0ece498 
…nsions after resizing.

Related to issue #1687
@estebanlm
add missing method
b6dfd7c
@estebanlm
add open/close events to popovers
3862a3a
@estebanlm
add a default popupModal implementation
23d5b34
@estebanlm
add popupModal to presenter (this has sense in gtk backend)
8e84364
@estebanlm
add select index to tab layout
819c6ce
@estebanlm
add selection events to tab layout
540f281
@estebanlm
add a fillWith: method to menu button
6178022 
to do exactly that: filling the menu using an action group
@estebanlm
quickly escape if no announcer defined
a1acf3b
@estebanlm
fix categorisation
ae2988f
@estebanlm
cleanup
d9d4b1e
@estebanlm
Merge b1c430c
2924d7a
@Ducasse
Merge pull request #1688 from AyechiNour/1687-SpSearchInputFieldPrese…
61314be 
…nterTest

A test that checks whether the elements stay within the window's dimensions after resizing.
@estebanlm
in certain cases, I am not sure I will use a one-argument block, so b…
c63ca7d 
…etter call with cull.
@estebanlm
add a convenience method to add many actions at a time
a1eb01b
@estebanlm
using a lowercase matching string on default select dialogs
b14c95a
@estebanlm
add a visible: method to presenters, to show/hide directly with an ar…
b13b8d0 
…gument (because yes, I use it)
@estebanlm
I added a generic visitor for presenters. This is mainly used when I …
7c49e24 
…need different behaviors in the presented model.
@estebanlm
Merge 61314be
539189f
@estebanlm
add a couple of helpers
90e8899
@estebanlm
Fixes #1707
b60a3dd
@estebanlm
add "nearWindowLike" to be able to find the first that is, well, like…
c4cb734 
… a window :P
@estebanlm
add some convenience methods (but I need to change the way I do modals)
fe060a7
@estebanlm
Fixed a problem where if I was browsing a variable (or class) it was …
1b2bba7 
…going to `theVariable browse` and not `self systemNavigation browse: theVariable`. The first one condem us to a hardcoded solution.

cleanup: using actionModifier instead a choice each time
@jecisc
Copy link
Member

jecisc commented Jan 23, 2025

One test seems to fail:

SpPresenterBuildTest
 ✗ #testBuildWidgetPresenterWillSetPresenterProperty (3ms)
Instance of SpActionBarPresenter class did not understand #isWindow
SpActionBarPresenter class(Object)>>doesNotUnderstand: #isWindow

@Ducasse
Copy link
Contributor

Ducasse commented Jan 30, 2025

@estebanlm I fixed the conflicts (there were quite strange)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@estebanlm @jecisc @Ducasse