Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure unique use of statistics identifiers #384

Merged
merged 4 commits into from
Feb 7, 2024
Merged

Ensure unique use of statistics identifiers #384

merged 4 commits into from
Feb 7, 2024

Conversation

phate
Copy link
Owner

@phate phate commented Feb 6, 2024 •
edited
Loading

We would like to use statistics identifiers as tags in our statistics logs, but for that they need to be (reasonably) descriptive and uniquely associated with a single pass in jlm. This PR accomplishes this, fixing parts of #361.

@phate phate requested a review from haved February 6, 2024 04:22
@phate phate linked an issue Feb 6, 2024 that may be closed by this pull request
Improve statistics serialization #361
Closed
@phate phate removed a link to an issue Feb 6, 2024
Improve statistics serialization #361
Closed
haved
haved approved these changes Feb 6, 2024
View reviewed changes
Copy link
Collaborator

@haved haved left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, it's interesting to note how many places you have to modify when changing an id. It will be very nice to create a single source of truth eventually.

@phate phate merged commit 4929e7f into master Feb 7, 2024
10 checks passed
@phate phate deleted the StatisticsId branch February 7, 2024 04:47
@phate phate mentioned this pull request Feb 29, 2024
Merged
phate added a commit that referenced this pull request Feb 29, 2024
@phate
Clean up serialization interface of Statistics class (#413)
8c4c301 
This is the last PR in series of PRs that refactored the Statistics
class serialization.

The other PRs are #384 and #382. Closes #361.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@haved haved haved approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@phate @haved