-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Roundtrip the undef node #660
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Only minor comments
@sjalander Alternatively, we could split the test in two: one for frontend and one for backend? |
@phate In this case we could, but that adds extra work as one then need to manually construct both the RVSDG and MLIR graph for the two individual tests. That's what we have done so far, but it is tedious work that doesn't contribute to improving the test coverage. This wouldn't work in general for the roundtrip tests we have talked about, where one create an RVSDG graph that gets converted to MLIR and then back to RVSDG-new and a simple comparison between RVSDG and RVSD-new is made. |
Place them in |
This PR roundtrips the undef node and provides a unit test for it.
In addition, it updates the commit hash used for building the mlir-rvsdg dialect to include the fix of the undef operation output type.