Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updated caching for CI CIRCT build #661

Merged
merged 7 commits into from
Oct 18, 2024
Merged

Updated caching for CI CIRCT build #661

merged 7 commits into from
Oct 18, 2024

Conversation

sjalander
Copy link
Collaborator

@sjalander sjalander commented Oct 16, 2024

The 'save-always: true' option is deprecated.
This version should have the advantage that even if the CI fails at a later step, the build should have already been saved and not require to be rebuilt when a fix is pushed.

@sjalander
Copy link
Collaborator Author

sjalander commented Oct 16, 2024

The Tests/build reported the following, so attempts are at least made to save the build.

Failed to save: Unable to reserve cache with key Linux-circt-2dc8240d91a0f993d616b152aa4d7520156862fe, another job may be creating this cache. More details: Cache already exists. Scope: refs/pull/661/merge, Key: Linux-circt-2dc8240d91a0f993d616b152aa4d7520156862fe, Version: 238d06c864bc65ace87e9f10bc2b1cb6c325b420ebcb72aafc883eb2332e7ee7
Warning: Cache save failed.

@sjalander sjalander requested a review from phate October 16, 2024 16:46
@sjalander sjalander enabled auto-merge (squash) October 16, 2024 16:49
.github/actions/BuildCirct/action.yml Outdated Show resolved Hide resolved
.github/actions/BuildCirct/action.yml Outdated Show resolved Hide resolved
@phate
Copy link
Owner

phate commented Oct 18, 2024

 NEEDRESTART-KSTA: 1
Run echo "hash=$(./scripts/build-circt.sh --get-commit-hash)" >> $GITHUB_OUTPUT
Run actions/cache/restore@v4
Received 0 of 540379106 (0.0%), 0.0 MBs/sec
Received 125829120 of 540379106 (23.3%), 59.9 MBs/sec
Received 268435456 of 540379106 (49.7%), 85.3 MBs/sec
Received 427819008 of 540379106 (79.2%), 102.0 MBs/sec
Cache Size: ~515 MB (540379106 B)
/usr/bin/tar -xf /home/runner/work/_temp/528636d8-afe7-4f39-bab5-22cd073bf6fa/cache.tzst -P -C /home/runner/work/jlm/jlm --use-compress-program unzstd
Received 540379106 of 540379106 (100.0%), 103.0 MBs/sec
Cache restored successfully
Cache restored from key: Linux-circt-2dc8240d91a0f993d616b152aa4d7520156862fe
Run ./scripts/build-circt.sh \
Cloning into '/home/runner/work/jlm/jlm/build-circt/circt.git'...
Note: switching to '2dc8240d91a0f993d616b152aa4d7520156862fe'.

@sjalander In the logs, it says that it successfully restored the cache, but then it goes ahead and builds CIRCT anyway. Is it not the point that if we have a cache hit, that we can avoid the rebuilding of CIRCT?

@sjalander
Copy link
Collaborator Author

 NEEDRESTART-KSTA: 1
Run echo "hash=$(./scripts/build-circt.sh --get-commit-hash)" >> $GITHUB_OUTPUT
Run actions/cache/restore@v4
Received 0 of 540379106 (0.0%), 0.0 MBs/sec
Received 125829120 of 540379106 (23.3%), 59.9 MBs/sec
Received 268435456 of 540379106 (49.7%), 85.3 MBs/sec
Received 427819008 of 540379106 (79.2%), 102.0 MBs/sec
Cache Size: ~515 MB (540379106 B)
/usr/bin/tar -xf /home/runner/work/_temp/528636d8-afe7-4f39-bab5-22cd073bf6fa/cache.tzst -P -C /home/runner/work/jlm/jlm --use-compress-program unzstd
Received 540379106 of 540379106 (100.0%), 103.0 MBs/sec
Cache restored successfully
Cache restored from key: Linux-circt-2dc8240d91a0f993d616b152aa4d7520156862fe
Run ./scripts/build-circt.sh \
Cloning into '/home/runner/work/jlm/jlm/build-circt/circt.git'...
Note: switching to '2dc8240d91a0f993d616b152aa4d7520156862fe'.

@sjalander In the logs, it says that it successfully restored the cache, but then it goes ahead and builds CIRCT anyway. Is it not the point that if we have a cache hit, that we can avoid the rebuilding of CIRCT?

It's now fixed.

@sjalander sjalander merged commit 5a0fa44 into master Oct 18, 2024
11 checks passed
@sjalander sjalander deleted the ci-cache branch October 18, 2024 17:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants