Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add implementation for similarity/frequency for genes corpus #206

Merged
merged 2 commits into from
Mar 13, 2020
Merged

Add implementation for similarity/frequency for genes corpus #206

merged 2 commits into from
Mar 13, 2020

Conversation

Shalsh23
Copy link
Contributor

Fixes #192

@Shalsh23 Shalsh23 requested a review from balhoff March 13, 2020 15:09
@Shalsh23 Shalsh23 self-assigned this Mar 13, 2020
@balhoff
Copy link
Member

balhoff commented Mar 13, 2020

@Shalsh23 I removed some code duplication. Can you test and the comment here that it works the same? Then we can merge.

@Shalsh23
Copy link
Contributor Author

@Shalsh23 I removed some code duplication. Can you test and the comment here that it works the same? Then we can merge.

Yup, tested. Seems good.

@balhoff balhoff merged commit 2261cf6 into master Mar 13, 2020
@balhoff balhoff deleted the issue-192-similarity-frequency branch March 13, 2020 15:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@balhoff balhoff balhoff approved these changes

Assignees

@Shalsh23 Shalsh23

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

/similarity/frequency returns nothing at least for some phenotypes for the genes corpus
2 participants
@Shalsh23 @balhoff