Add Android 10 base, and fixing bugs #773
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KomodoOS have new branch for GSI (pie-gsi), so i update from -b=pie become -b=pie-gsi, and also i add some github branch that refers to future Android 10 release for most custom ROMs (even though some of them are dummy and can replaced later)
Most ROMs have android 10 codebase, so i add the branch link to build-dakkar (although some of it are dummy and can replaced later), and changing branch from pie to pie-gsi in KomodoOS to prevent build error
Some of custom ROMs have Android 10 base, so i add all android 10 base (although some of them are dummy and can replaced later), and fixing some scripts, such as replacing pie to pie-gsi in KomodoOS, and adding AtomOS
phhusson
reviewed
Oct 14, 2019
| extra_make_options="" | ||
| jack_enabled="true" | ||
| ;; | ||
| aosp90) | ||
| mainrepo="https://android.googlesource.com/platform/manifest.git" | ||
| mainbranch="android-9.0.0_r21" | ||
| localManifestBranch="android-9.0" | ||
| treble_generate="" | ||
| treble_generate="aosp" |
AreYouLoco
suggested changes
Dec 27, 2019
| @@ -248,14 +373,30 @@ function get_rom_type() { | |||
| extra_make_options="WITHOUT_CHECK_API=true" | |||
| jack_enabled="false" | |||
| ;; | |||
| havoc-10) | |||
| mainrepo="https://github.com/Havoc-OS/android_manifest.git" | |||
| mainbranch="10" | |||
There was a problem hiding this comment.
Its "ten" branch in the Havoc manifest repo not "10".
tkubasik1
approved these changes
Apr 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some of custom ROMs have Android 10 base, so i add most android 10 base (although some of them are dummy and can replaced later), and fixing some scripts, such as replacing pie to pie-gsi in KomodoOS, and adding AtomOS