Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

script: function get_mk #87

Closed
wants to merge 1 commit into from
Closed

Conversation

Dil3mm4
Copy link
Contributor

@Dil3mm4 Dil3mm4 commented Jun 18, 2018

Nothing more than a wget on raw content based on treble_generate content

Nothing more than a wget on raw content based on treble_generate content
@phhusson
Copy link
Owner

I'd rather add https://raw.github.com/phhusson/rom_makefiles to manifest
And have build_dakkar inherit vendor/rom_makefiles/${rom}.mk instead of downloading to device/phh/treble/${rom}.mk

As for the concern of destroying dev-s current work, we can either mention this in readme (expected repo way is to repo start vendor/rom_makefiles name-of-my-own-branch, and then the local commits will remain after repo sync-s), or just add a git stash/git stash apply in the build script + ignore git clean -fdx.
I think the repo start way is better, because people will better understand how to work with the rest of the sources. Though this will conflict with apply-patches

@Dil3mm4
Copy link
Contributor Author

Dil3mm4 commented Jun 18, 2018

#89

@Dil3mm4 Dil3mm4 closed this Jun 18, 2018
onde2rock pushed a commit to onde2rock/treble_experimentations that referenced this pull request Apr 3, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants