Refactor: Cleanup playground file #1155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ashpreetbedi
requested changes
Sep 26, 2024
phi/playground/operator.py
Outdated
| from typing import List, Optional | ||
|
|
||
| from phi.agent.agent import Agent, Tool, Toolkit, Function | ||
| from phi.utils.log import logger |
There was a problem hiding this comment.
update import ordering
from phi.agent.session import AgentSession
from phi.utils.log import logger
phi/playground/playground.py
Outdated
| class GetAgentSessionsResponse(BaseModel): | ||
| session_id: Optional[str] = None | ||
| title: Optional[str] = None | ||
| from .routes import create_playground_routes |
There was a problem hiding this comment.
not a fan of relative routes, lets use phi.playground.routes
There was a problem hiding this comment.
more info: https://peps.python.org/pep-0008/#imports
|
|
||
| from pydantic import BaseModel | ||
| from phi.agent.agent import Agent, RunResponse, Tool, Toolkit, Function | ||
| from phi.agent.agent import Agent | ||
| from phi.playground.settings import PlaygroundSettings | ||
| from phi.utils.log import logger |
phi/playground/routes.py
Outdated
| from phi.agent.agent import Agent, RunResponse | ||
| from phi.utils.log import logger | ||
| from phi.agent.session import AgentSession | ||
| from .operator import get_agent_by_id, get_session_title, format_tools |
There was a problem hiding this comment.
please use absolute imports
phi/playground/routes.py
Outdated
| from fastapi.responses import StreamingResponse, JSONResponse | ||
|
|
||
| from phi.agent.agent import Agent, RunResponse | ||
| from phi.utils.log import logger |
There was a problem hiding this comment.
import ordering, phi.utils should be at the end
| @@ -0,0 +1,133 @@ | |||
| from typing import List, Optional, Generator, Dict, cast, Union | |||
| import base64 | |||
There was a problem hiding this comment.
base64 should be at the top
| @@ -0,0 +1,133 @@ | |||
| from typing import List, Optional, Generator, Dict, cast, Union | |||
| import base64 | |||
| from fastapi import APIRouter, HTTPException, UploadFile | |||
There was a problem hiding this comment.
new line between std lib imports and 3rd party imports
ysolanky
approved these changes
Sep 27, 2024
ysolanky
reviewed
Sep 27, 2024
phi/playground/routes.py
Outdated
| from phi.playground.operator import format_tools, get_agent_by_id, get_session_title | ||
| from phi.utils.log import logger | ||
|
|
||
| from .schemas import ( |
There was a problem hiding this comment.
@manthanguptaa here we should do phi.playground.schemas
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.