Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make older functions compatible with tool calling #1605

Merged
merged 13 commits into from
Dec 20, 2024

Conversation

dirkbrnd
Copy link
Contributor

Description

Some older custom function implementations where the description and parameters were manually specified (e.g. as built in composio-phidata) were not compatible with the new way of building tools for models.

This addresses it by keeping parameters/description if it was set on the Function.

Type of change

Please check the options that are relevant:

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Model update
  • Infrastructure change

Checklist

  • My code follows Phidata's style guidelines and best practices
  • I have performed a self-review of my code
  • I have added docstrings and comments for complex logic
  • My changes generate no new warnings or errors
  • I have added cookbook examples for my new addition (if needed)
  • I have updated requirements.txt/pyproject.toml (if needed)
  • I have verified my changes in a clean environment

Additional Notes

Include any deployment notes, performance implications, or other relevant information:

@dirkbrnd dirkbrnd changed the base branch from main to release/2.7.5 December 20, 2024 12:21
@dirkbrnd dirkbrnd merged commit 8683f07 into release/2.7.5 Dec 20, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants