-
Notifications
You must be signed in to change notification settings - Fork 2.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support o1 developer message format #1717
Conversation
This lools good but my only concern is that we can't test it with o1 yet because of not having access to it |
This is true, but this allows users that already have o1 to atleast continue, which is the case for the user that raised the issue. We can confirm with them that it works. According to OpenAI and other articles, this should be the only required change. And we can confirm it works on older models, so we know we have the interface correct. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tested against sambanova, together, and openai cookbooks and this working perfectly
@dirkbrnd / @manthanguptaa This change broke the Deepseek and I think will break other OpenAILike models. error:
Did not try other providers, but with deepseek I can see above issue. |
Thanks for raising, we have merged a fix. Releasing with 2.7.8. |
Description
OpenAI's o1 model requires
system
messages to bedeveloper
messages going forward. This change is backwards compatible with older models.Fixes #1621
Note We don't yet have access to o1, so we cannot confirm whether o1 itself works yet. This only paves the way for it.
Type of change
Please check the options that are relevant:
Checklist