Skip to content

Commit

Permalink
Merge pull request #26 from philbates35/typed-consts
Browse files Browse the repository at this point in the history
Upgrade to phpcs 3.9 and re-enable AddTypeToConstRector rule
  • Loading branch information
philbates35 authored Feb 23, 2024
2 parents 5c8b5a5 + 13d0155 commit b1657bc
Show file tree
Hide file tree
Showing 2 changed files with 8 additions and 13 deletions.
10 changes: 5 additions & 5 deletions composer.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

11 changes: 3 additions & 8 deletions rector.php
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
declare(strict_types=1);

use Rector\Config\RectorConfig;
use Rector\Php83\Rector\ClassConst\AddTypeToConstRector;
use Rector\PHPUnit\Set\PHPUnitSetList;
use RectorLaravel\Set\LaravelSetList;

Expand All @@ -21,9 +20,9 @@
// Larastan's bootstrap file doesn't run when Rector boots PHPStan, so we need to include it manually. See:
// * https://github.com/rectorphp/rector/issues/8006
// * https://github.com/larastan/larastan/issues/1664#issuecomment-1637152828
->withBootstrapFiles([__DIR__ . '/vendor/larastan/larastan/bootstrap.php'])
// All extensions except PHPStan bleeding edge. See:
// * https://github.com/rectorphp/rector/issues/8492#issuecomment-1944428821
->withBootstrapFiles([
__DIR__ . '/vendor/larastan/larastan/bootstrap.php',
])
->withPHPStanConfigs([
__DIR__ . '/phpstan.neon.dist',
])
Expand All @@ -49,8 +48,4 @@
])
->withSkip([
__DIR__ . '/bootstrap/cache',

// TODO Stop skipping this rule as soon as phpcs supports typed const
// See: https://github.com/PHPCSStandards/PHP_CodeSniffer/issues/106
AddTypeToConstRector::class,
]);

0 comments on commit b1657bc

Please sign in to comment.