tsconfig: Use ESNext in target and lib #23
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
From what I can tell, the value of target doesn't actually matter, because we have noEmit set to true - its esbuild in dev (configured by Vite's esbuild.target) and Rollup for prod build (configured by build.target) that do the transpiling, but there's no harm in updating it anyway. Setting "lib" to include ESNext allows us to use more modern features such as "promise.any, string.replaceAll etc" (ES2021) and "array.at, RegExp.hasIndices, etc." (ES2022). Its also worth noting that these are the values of the tsconfig.json that come when using Laravel Breeze with one of its TS starters. See: * https://www.typescriptlang.org/tsconfig#lib * https://www.typescriptlang.org/tsconfig#target * https://github.com/laravel/breeze/blob/095c4c597c3719e2a596fcf4689288e9cdbc6520/stubs/inertia-react-ts/tsconfig.json
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
From what I can tell, the value of target doesn't actually matter, because we have
noEmitset to true - its esbuild in dev (configured by Vite'sesbuild.target) and Rollup for prod build (configured bybuild.target) that do the transpiling, but there's no harm in updating it anyway.Setting
libto includeESNextallows us to use more modern features such as "promise.any, string.replaceAll etc" (ES2021) and "array.at, RegExp.hasIndices, etc." (ES2022).Its also worth noting that these are the values of the
tsconfig.jsonthat come when using Laravel Breeze with one of its TS starters.See: