Dockerfile: Run composer install in ENTRYPOINT #4
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
philbates35
force-pushed
the
update-dockerfile
branch
from
505d460 to
7f60e3e
Compare
I realised going through the docs the getting started steps on a fresh project didn't work, there were a couple of issues: 1. The .env wasn't being created 2. The composer:latest used to do the initial "composer install" uses PHP8.2 but the project requires PHP8.3 so it fails. It makes much more sense to do the "composer install" as part of the initial "docker-compose up" meaning one less step for the developer.
philbates35
force-pushed
the
update-dockerfile
branch
from
7f60e3e to
106c542
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I realised going through the docs the getting started steps on a fresh project didn't work, there were a couple of issues:
.envwasn't being createdcomposer:latestused to do the initialcomposer installuses PHP8.2 but the project requires PHP8.3 so it fails. It makes much more sense to do thecomposer installas part of the initialdocker-compose upmeaning one less step for the developer.