Various fixes #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 6 commits
January 19, 2024 08:34
Based on Finder::__construct it seems that Finder::exclude is more appropriate for directories even though they appear to have the same output.
Make sure the config file adheres to its own rules.
Go through every rule in the documentation, and define those rules that aren't already included in the rule sets that are being used. Most of them are enabled, a few are not enabled either for person preference or because they're just not relevent (e.g. the Doctrine rules).
Based on https://laravel.com/docs/10.x/localization#handling-missing-translation-strings. Use "resolving" callback instead of using the Log facade / the 'log' service because if we do that it will force the deferred LogServiceProvider to be registered on every request, essentially making it not deferred any more. Similar to how Model::shouldBeStrict() is only called when not in production, we only throw an exception when not in production.
philbates35
force-pushed
the
various-fixes
branch
from
431862b to
51a8bbc
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See each commit for details.