Skip to content

Commit

Permalink
Adds Pipfile support (#25)
Browse files Browse the repository at this point in the history
* Added ability to read local metadata and search for funding links

* Fixes running tests via tox

Corrected linting errors and removed rouge 'print' calls.

Moved to using nosetest as the setup.py test runner. This is mainly as nose
give clearer error messages when something goes wrong.

Also of note there were pinned dependencies which have been changed to
'at least' version dependencies. For reasons why see
https://caremad.io/posts/2013/07/setup-vs-requirement/

Laster, we currently have a README.md and a README.rst. I'm unsure which one of these
we mean to use. Shouldn't we at the very least keep all of the following in
the same markup format: README, HISTORY, CONTRIBUTING, AUTHORS,

* Attempts to make clever code more readable

* Refactors cli and thanks.py in preparation Pipfile processing

* Adds logger and activate level=DEBUG on cli flag

* Adds ability to process Pipfile's

* Flake8ification

* Corrects relative import for py27

* Addresses @phildini suggestions

- thanks.rocks is confusing
- removes commented out code

* Fixes travis test invocation and updates tox to match

- Moves to py.test as gives better error messages

* Forced add fixture files (.egg) which were causing failing tests

.egg files are sensibly added to .gitignore
This is probably one of the very few cases where you want to
add a .egg file :)
  • Loading branch information
tomdottom authored and phildini committed Jun 28, 2018
1 parent b26aadd commit 4059095
Show file tree
Hide file tree
Showing 16 changed files with 1,961 additions and 68 deletions.
1 change: 1 addition & 0 deletions .travis.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,6 +14,7 @@ install:
# Command to run tests, e.g. python setup.py test
script:
- flake8 thanks
- pip list
- python setup.py test


1 change: 1 addition & 0 deletions requirements_dev.txt
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,4 @@ coverage==4.4.2
Sphinx==1.6.5
twine==1.9.1
ddt
pytest
2 changes: 1 addition & 1 deletion setup.cfg
Original file line number Diff line number Diff line change
Expand Up @@ -19,4 +19,4 @@ exclude = docs
max-line-length = 120

[aliases]

test=pytest
5 changes: 3 additions & 2 deletions setup.py
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,15 @@
'termcolor>=1',
'setuptools>=',
'requests>=2',
'toml'
]

setup_requirements = [
'nose'
"pytest-runner"
]

test_requirements = [
"pytest",
'ddt',
]

Expand Down Expand Up @@ -62,7 +64,6 @@
'Programming Language :: Python :: 3.5',
'Programming Language :: Python :: 3.6',
],
test_suite='nose.collector',
tests_require=test_requirements,
setup_requires=setup_requirements,
)
Loading

0 comments on commit 4059095

Please sign in to comment.