Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Map does not render in version django 1.11. #83

Open
marlonleite opened this issue May 7, 2017 · 25 comments
Open

Map does not render in version django 1.11. #83

marlonleite opened this issue May 7, 2017 · 25 comments

Comments

@marlonleite
Copy link

After several tests, I realized that the map does not render in the version of django 1.11. Already in version 1.10 works perfectly.

@vladimirmyshkovski
Copy link

Faced with exactly the same problem.
There is no js error, the map is not rendered, and there are no headings "latitude", "longitude"

@wjdp
Copy link

wjdp commented May 10, 2017

Seeing the same

@philippbosch
Copy link
Owner

@marlonleite @narnikgamarnikus @wjdp I'm not currently using django-geoposition in a Django >1.9 project. Would one of you be able to provide a fix for this by any chance?

@wjdp
Copy link

wjdp commented May 10, 2017

Happy to take a look

@wjdp
Copy link

wjdp commented May 24, 2017

For those on 1.11 waiting for a release you can do pip install https://github.com/philippbosch/django-geoposition/archive/django-1.11.zip in the meantime

@Alexx-G
Copy link

Alexx-G commented Jun 9, 2017

@philippbosch Is there any blocker for merging those fixes into master and releasing the package?

@AkhilLabGlo
Copy link

I am also facing the issue of map not rendering in admin page, django-1.11

@Alexx-G
Copy link

Alexx-G commented Jun 21, 2017

@AkhilLabGlo I'm using the version from django-1.11 branch as @wjdp pointed out.
It would be nice to get a release, but it works as a temporary solution.
Seems like the author doesn't use 1.11, so it's not a critical issue in his use cases. However, for most of my projects, I keep actual version of Django via incremental upgrades (not a lot of updates are needed usually), so it was a blocker for me.

@iang12
Copy link

iang12 commented Oct 7, 2017

I also use django 1.11 and I'm having the same problem rendering the map, but I used the temporary solution above and it worked!

@elcolie
Copy link

elcolie commented Nov 12, 2017

Hi. I am using pip-tools. How can I pin down the requirements.in?
jazzband/pip-tools#593

@talbenbasat
Copy link

Any updates about 1.11?

@andrewmwilson
Copy link

It would be very nice to get a release if possible.

@NgariC
Copy link

NgariC commented May 2, 2018

map not rendering in django 2.0 how can i correct this

@elcolie
Copy link

elcolie commented May 2, 2018

@NgariC #100

@andreyshipilov
Copy link

Still not fixed. Django 1.11.6

@darccio
Copy link

darccio commented Oct 11, 2018

Any ETA for releasing a Django 1.11 compatible version? Thanks!

@andreyshipilov
Copy link

Guys, it's been more than a year and this is still not fixed...

@darccio
Copy link

darccio commented Oct 26, 2018

As several others, I created a fork. My forks has support for Django 1.11 and 2.x from other forks and a minor fix to avoid django's Javascript global var conflicts: https://github.com/imdario/django-geoposition

@andreyshipilov
Copy link

andreyshipilov commented Oct 27, 2018

@imdario Your fork throws errors in admin. Have you tested it in 1.11?

super() takes at least 1 argument (0 given)

Over here: https://github.com/imdario/django-geoposition/blob/master/geoposition/widgets.py#L23

@darccio
Copy link

darccio commented Oct 27, 2018 via email

@andreyshipilov
Copy link

@imdario Absolutely.

If you change:

context = super().get_context(name, value, attrs)

to Py2 style:

context = super(GeopositionWidget, self).get_context(name, value, attrs)

then voila.
screen shot 2018-10-27 at 8 24 25 pm

@darccio
Copy link

darccio commented Oct 28, 2018

@andreyshipilov, fixed and released as v0.3.5.

@andreyshipilov
Copy link

@imdario Awesome! Cheers mate :)

@jvorcak
Copy link

jvorcak commented Dec 5, 2018

Hi @imdario,

I'm using Django 2.0.9 and django-geoposition=0.3.0
and this widget doesn't work in Admin.

Can I ask you how can I install 0.3.5?

screen shot 2018-12-05 at 11 10 58

@darccio
Copy link

darccio commented Dec 5, 2018

@jvorcak, it looks I forgot to update the README in order to point to my own PyPI package: django-geoposition-2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests