Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add django 1.11 support #84

Merged
merged 2 commits into from
May 10, 2017
Merged

Conversation

wjdp
Copy link

@wjdp wjdp commented May 10, 2017

Will close #83.

Issue is django removed the format_output method from forms.MultiWidget, see https://docs.djangoproject.com/en/1.11/releases/1.11/#changes-due-to-the-introduction-of-template-based-widget-rendering.

I've tried to keep support for both >1.11 and <=1.10 by adding a template_name and get_context to GeopositionWidget but leaving the existing format_output.

It's working on 1.11, have not checked on 1.10 or 1.8.

@philippbosch philippbosch changed the base branch from master to django-1.11 May 10, 2017 15:53
@philippbosch
Copy link
Owner

Thanks @wjdp for this!!
I'm merging this into a django-1.11 branch first in order to change the test settings and include 1.11 before merging into master.

@philippbosch philippbosch merged commit a212ca6 into philippbosch:django-1.11 May 10, 2017
@rcotrina94
Copy link

rcotrina94 commented May 24, 2017

[...] change the test settings and include 1.11 before merging into master.

Done in #85 and #86 :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants