Make normalizeVector(v) in place

[erikdubbelboer]

All usage of normalizeVector was in the form of

    v = normalizeVector(v)

In that case it's better to just do the replacement in place and not having to allocate a new slice.

[philippgille]

Thanks for the suggestion!

I'm worried that for the places where the user passes an existing embedding (e.g. as Add() parameter, Document.Embedding field in AddDocument() or QueryEmbedding() parameter), they could be surprised to have it changed and they might want to continue using their slice in their code, where it might need to be the unnormalized form.

Do you have a use case where the allocation is an issue (noticeable/measurable memory usage performance difference)?

Could it be an option to have both normalize functions, and call the in-place one only when the embedding is not user-supplied?

[erikdubbelboer]

I agree that with a library like this the performance overhead of some extra garbage collection probably isn't going to be measurable.