-
Notifications
You must be signed in to change notification settings - Fork 8
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add support to return resolve MAC address #464
Open
cassio-lazaro
wants to merge
5
commits into
philips-software:main
Choose a base branch
from
cassio-lazaro:feature/add-support-to-resolve-mac-address
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
feat: add support to return resolve MAC address #464
cassio-lazaro
wants to merge
5
commits into
philips-software:main
from
cassio-lazaro:feature/add-support-to-resolve-mac-address
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was referenced Dec 11, 2024
richardapeters
changed the title
feat!: add support to return resolve MAC address
feat: add support to return resolve MAC address
Dec 19, 2024
richardapeters
approved these changes
Dec 19, 2024
cassio-lazaro
force-pushed
the
feature/add-support-to-resolve-mac-address
branch
from
December 19, 2024 14:33
aace71f
to
378261b
Compare
cassio-lazaro
force-pushed
the
feature/add-support-to-resolve-mac-address
branch
from
December 30, 2024 11:17
378261b
to
5ab42dd
Compare
richardapeters
approved these changes
Jan 3, 2025
cassio-lazaro
force-pushed
the
feature/add-support-to-resolve-mac-address
branch
3 times, most recently
from
January 14, 2025 10:25
7de7bb7
to
0975ed6
Compare
oguzcanoguz
requested changes
Jan 14, 2025
Return the resolved MAC address instead of the random one
cassio-lazaro
force-pushed
the
feature/add-support-to-resolve-mac-address
branch
2 times, most recently
from
January 16, 2025 14:35
2d7bffa
to
4a838e9
Compare
cassio-lazaro
force-pushed
the
feature/add-support-to-resolve-mac-address
branch
from
January 16, 2025 14:42
4a838e9
to
c572283
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Return the resolved MAC address instead of the random one.
All the PRs have to be ready beforehand and merged in sequence.
Related work
Details
I've changed the CMake to use a different embedded-infra-lib due to the dependency. It will be removed before merging it.