Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Getting spans into applied and identified lists appropriately #127

Merged
merged 8 commits into from
Aug 14, 2024

Conversation

jzonthemtn
Copy link
Member

@jzonthemtn jzonthemtn commented Aug 13, 2024

Adds an applied property to Span. Spans that are not applied are put into the identified list.

For #126

Copy link
Collaborator

@robfromboulder robfromboulder left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good -- I tried out these changes with phileas-benchmark test cases as well, and looks good to merge. Thanks so much!!!

@jzonthemtn jzonthemtn merged commit 4f51765 into main Aug 14, 2024
3 checks passed
@jzonthemtn jzonthemtn deleted the 126-conditions branch August 14, 2024 11:12
JessieAMorris pushed a commit to JessieAMorris/phileas that referenced this pull request Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants