-
-
Notifications
You must be signed in to change notification settings - Fork 320
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow new version of sebastian/version for phpunit 11 compatibility #1864
Allow new version of sebastian/version for phpunit 11 compatibility #1864
Conversation
Running into the same problem as well, any estimation for when this will be merged @mrook ? In advance, i appreciate all the effort (: |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1864 +/- ##
=========================================
Coverage 53.57% 53.57%
Complexity 9809 9809
=========================================
Files 495 495
Lines 24198 24198
=========================================
Hits 12963 12963
Misses 11235 11235 ☔ View full report in Codecov by Sentry. |
@tkegan Thanks for your contribution. Would you mind to include the generated |
Hi, is it possible to merge this pull request in the near future? |
Sorry I've been on call and I was kept hopping. I'm not sure I understand. There are no changes to the It may be helpful to see phpunit 11 coexisting with phing in a project; so I threw together a stripped down sample project you can try here https://github.com/tkegan/phing-sample. Hopefully this helps. If not or there is something more I can do please let me know. |
@siad007 do you think it would be possible to create a version 3.0.1 ? We are locked on 3.0.0 which doesn't have the fix so it's impossible to upgrade to phpunit 11 still |
Hi @bbouchard-seedbox we just released Phing 3.0.1. |
This PR recreates PR #1831 which I mistakenly closed thinking it to be obsolete. If accepted, this PR updates the allowed versions of the dependency
sebastian/version
allowingphing
to be used in projects which wish to use phpunit version 11.x for testing.Note because
phing
usesphpunit
version 9 for unit testing which depends onsebastian/version
version 3.x running unit tests alone is not a sufficient test of this dependency change. Instead a project needs to be created usingphing
andphpunit
(at version 11) and thebuild.xml
needs to include a target which invokesPhing::getPhingVersion
. I've tried this in a closed source project but can come up with a stripped down example if desired.