Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Introduce DisguiseLogger #1868

Merged
merged 5 commits into from
Sep 28, 2024
Merged

Introduce DisguiseLogger #1868

merged 5 commits into from
Sep 28, 2024

Conversation

siad007
Copy link
Member

@siad007 siad007 commented Sep 27, 2024

Related to #1672

  • Added DisguiseLogger

Using this logger prevents output logging for passwords in URIs and mask them with *****

build.xml

<project name="Test" default="test" basedir=".">
    <target name="test">
        <echo msg="some text and a link to http://foo:[email protected]/baz?one=two" />
    </target>
</project>

using logger

phing -logger "Phing\Listener\DisguiseLogger" -f build.xml

output

     [echo] some text and a link to http://foo:*****@example.com/baz?one=two

Copy link

codecov bot commented Sep 27, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.62%. Comparing base (12a6299) to head (474a867).
Report is 1 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main    #1868      +/-   ##
============================================
+ Coverage     53.59%   53.62%   +0.03%     
- Complexity     9812     9820       +8     
============================================
  Files           495      496       +1     
  Lines         24205    24222      +17     
============================================
+ Hits          12973    12990      +17     
  Misses        11232    11232              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@siad007 siad007 merged commit 578b7de into main Sep 28, 2024
74 checks passed
@siad007 siad007 deleted the feature/HidePasswords branch September 28, 2024 13:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Development

Successfully merging this pull request may close these issues.

1 participant