Use getenv() function instead of $_ENV global variable. #1887
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… variable. The PropertyTask's "environment" attribute fails to work as expected in some systems, sometimes $_ENV is an empty array. This behavior is system-dependent and determined by the "variables_order" directive in php.ini. To fix this I replaced $_ENV by getenv() function, as this ensures a consistent behaviour. * https://www.php.net/manual/en/ini.core.php#ini.variables-order * https://stackoverflow.com/questions/8798294/getenv-vs-env-in-php
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1887 +/- ##
=========================================
Coverage 53.37% 53.37%
Complexity 9818 9818
=========================================
Files 496 496
Lines 24738 24738
=========================================
+ Hits 13203 13204 +1
+ Misses 11535 11534 -1 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The PropertyTask's "environment" attribute fails to work as expected in some systems, sometimes $_ENV is an empty array.
This behavior is system-dependent and determined by the "variables_order" directive in php.ini.
To fix this I replaced $_ENV by getenv() function, as this ensures a consistent behaviour.