Dynamics for multis #947
Open
Dynamics for multis #947
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Note: Remeshing does not work. :-(
Elements in Jacobi coordinates -> barycentric frame. A 1:1 correspondence to nbody.py (rebound). As of now, no ltte, Euler angles, dpdt, dperdt, ...
Euler angles. Roche parameters. Hierarchical systems. Twopairs systems.
If import reboundx doesn't work, use workaround export LD_LIBRARY_PATH=~/.local/lib/python3.9/site-packages/
aprsa
reviewed
Oct 9, 2024
phoebe/dynamics/coord_b2j.py
Outdated
| @@ -0,0 +1,60 @@ | |||
| #!/usr/bin/env python3 | |||
There was a problem hiding this comment.
Can you please consolidate all source files related to transformations into a single python file, say transformations.py, so that we have everything in one place? Also, could you move executable parts to a test suite so that it's run alongside other tests? Finally, could you write up a high level documentation for the new implementation? It would be good to put our heads together and discuss naming -- for example, 'xyz' vs. 'cartesian' and similar.
Using user-defined force 'j2' instead of 'gravitational harmonics', where the z-axis was assumed to be fixed, not perpendicular to the respective orbit(s). For the moment, 'j2' must be added as follows: https://sirrah.troja.mff.cuni.cz/~mira/tmp/phoebe2/reboundx/
Each component has its own rotation axis, with respect to which the acceleration must be computed (and transformed back to the inertial frame). For the moment, src/gravitational_harmonics.c must be modified: https://sirrah.troja.mff.cuni.cz/~mira/tmp/phoebe2/reboundx_j2_/
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Re-implementation of Keperian dynamics for N bodies, so that it is compatible with Rebound numerical integrator.