python 3.13 support #968
Merged
python 3.13 support #968
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Closed
kecnry
commented
Oct 23, 2024
This comment was marked as resolved.
This comment was marked as resolved.
aprsa
reviewed
Oct 25, 2024
| @@ -12024,7 +12024,8 @@ def _value(var, string_safe_arrays=False, use_distribution=None, needs_builtin=F | |||
| # to do from builtin import * (and even if I did, python | |||
| # yells at me for doing that), so instead we'll add them | |||
| # to the locals dictionary. | |||
| locals()[func] = getattr(builtin, func) | |||
| # See https://peps.python.org/pep-0667/ | |||
| sys._getframe().f_locals[func] = getattr(builtin, func) | |||
There was a problem hiding this comment.
do you know perhaps what is the earliest version of python for which this will work?
There was a problem hiding this comment.
no, but it passes on the full CI matrix (3.8+).
* when actually releasing, we should consider which python version we want covered for tests, for now I'm limiting to only 3.13, but we don't want to merge this way
* no longer tested on GH, past end of life
* will drop 3.8 once GH runner is no longer available, technically past end of life
[skip ci]
aprsa
approved these changes
Oct 25, 2024
Merged
kecnry
added a commit
that referenced
this pull request
Oct 25, 2024
* Fix handling of floating-point precision near the aligned case that used to result in error from libphoebe. [#965] * Updates to phoebe-server to be compatible with modern browser requirements. [#959] * Fix support for python 3.13, remove official support for python 3.7. [#968] --------- Co-authored-by: Martin Horvat <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR is to test python 3.13 support and eventually make phoebe compatible.
Before merge:
Closes #967