Vectorization of passband computations #972
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It still runs the loops, but it computes auxiliary quantities outside of the loop.
This brings down per-passband computation from ~1 day to ~5 minutes.
aprsa
added
the
optimization
Raindogjones
approved these changes
Oct 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extinction has been computed serially, which caused the computations to take a long time (~1 day per passband). The new vectorized approach for both blackbody atmospheres and model atmospheres speeds this up to ~5 minutes per passband. The generated tables were checked for correctness and they're indistinguishable from the previous runs to machine precision.