Revive contact smoothing #989
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… teffratio from bundle
|
can you please either rebase or merge |
…ntact-smoothing # Conflicts: # phoebe/frontend/default_bundles/default_binary.bundle # phoebe/frontend/default_bundles/default_contact_binary.bundle # phoebe/frontend/default_bundles/default_star.bundle
aprsa
requested changes
Dec 18, 2024
kecnry
reviewed
Dec 19, 2024
aprsa
approved these changes
Jan 6, 2025
| b.set_value('mixing_method', 'perfect') # since other mixing methods are arbitrarily parametrized, test this case only | ||
| b.set_value('columns', '*') # to populate 'teffs' | ||
|
|
||
| assert b.run_checks().passed |
There was a problem hiding this comment.
I'm guessing that, eventually, we'll be able to do better than just test passing checks? It would also be good to find a way to test other mixing methods, but that shouldn't hold up this PR.
| b.set_value('teff@secondary', 3000) # so we have different temperatures | ||
| b.set_value('mixing_enabled', True) | ||
| b.set_value('mixing_method', 'perfect') # since other mixing methods are arbitrarily parametrized, test this case only | ||
| b.set_value('columns', '*') # to populate 'teffs' |
There was a problem hiding this comment.
- is a bit of an overkill; why not just add teffs?
| "extern_atmx", | ||
| "extern_planckint", | ||
| "blackbody", | ||
| "ck2004", |
There was a problem hiding this comment.
all the changes to this file are inconsequential; I'd leave the original version.
| @@ -144,7 +144,7 @@ null | |||
| "kind": "star", | |||
| "context": "component", | |||
| "description": "Critical (maximum) value of the equivalent radius for the given morphology", | |||
| "value": 2.0132751765376384, | |||
| "value": 2.013275176537638, | |||
There was a problem hiding this comment.
all the changes to this file are inconsequential; I'd leave the original version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replacement PR of #953.
Reinstates the code of @gecheline, @aprsa and @kecnry to handle contact binaries exchanging energy at the surface.
I've added the "perfect mixing" case which assumes very efficient mixing in the interior and makes the whole surface barotropic. This case is parameter-free and enables an easy test to be done.
TODO: