forked from MystenLabs/sui
-
Notifications
You must be signed in to change notification settings - Fork 0
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
[consensus] Switch to certified vote scoring & incrementally score su…
…bdags (MystenLabs#18806) After analyzing the results of our Leader Scoring Strategy experimentation. We will be switching from a Vote scoring strategy to a Certified Vote Scoring Strategy. This has shown improvements of about ~90ms for P50 latency with 6K mixed TPS in private-testnet. We can see that this scoring strategy gives us the best distribution of scores, as scores are distributed together across major geographic regions which improves our quorum latency. As part of this change we also moved to an incremental scoring process with a new struct called ScoringSubdag that keeps track of the votes for leaders and relevant stake for eventual reputation score calculation. Also removed the ReputationScoreCalculator & LeaderScoringStrategy components as we are now finalizing on the scoring strategy we will be using. Full experiment results : https://www.notion.so/mystenlabs/Leader-Scoring-Strategy-f11bbbd1055e453f9f0f5490544941ed?pvs=4 ## Testing - [x] unit tests & simtests - [ ] run certified vote v2 & v3 with incremental scoring in private-testnet and finalize on one - [ ] run upgrade test from vote scoring to certified vote scoring
- Loading branch information
1 parent
00e2d71
commit 072fcfb
Showing
13 changed files
with
1,527 additions
and
534 deletions.
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.