Ensure Non Zero Bridge Amount (MystenLabs#17745)

https://hackenproof.com/manager/sui/sui-protocol/reports/SUIPR-94
phoenix-o · May 15, 2024 · e2dc6ad · e2dc6ad
1 parent f1aba95
commit e2dc6ad
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 0 deletions.
diff --git a/bridge/evm/contracts/SuiBridge.sol b/bridge/evm/contracts/SuiBridge.sol
@@ -156,6 +156,8 @@ contract SuiBridge is ISuiBridge, CommitteeUpgradeable, PausableUpgradeable {
             IERC20Metadata(tokenAddress).decimals(), config.tokenSuiDecimalOf(tokenID), amount
         );
 
+        require(suiAdjustedAmount > 0, "SuiBridge: Invalid amount provided");
+
         emit TokensDeposited(
             config.chainID(),
             nonces[BridgeUtils.TOKEN_TRANSFER],

diff --git a/bridge/evm/test/SuiBridgeTest.t.sol b/bridge/evm/test/SuiBridgeTest.t.sol
@@ -548,6 +548,12 @@ contract SuiBridgeTest is BridgeBaseTest, ISuiBridge {
         reentrantAttack.attack();
     }
 
+    function testSuiBridgeInvalidDecimalConversion() public {
+        IERC20(wETH).approve(address(bridge), 10 ether);
+        vm.expectRevert(bytes("SuiBridge: Invalid amount provided"));
+        bridge.bridgeERC20(BridgeUtils.ETH, 1, abi.encode("suiAddress"), 0);
+    }
+
     // An e2e token transfer regression test covering message ser/de and signature verification
     function testTransferSuiToEthRegressionTest() public {
         address[] memory _committee = new address[](4);