Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

complex: add commonly used complex number funcs #272

Merged
merged 1 commit into from
Jul 24, 2023
Merged

complex: add commonly used complex number funcs #272

merged 1 commit into from
Jul 24, 2023

Conversation

gerard5
Copy link
Contributor

@gerard5 gerard5 commented Jul 21, 2023

Provide required complex.h function prototypes and commonly used functions.

cabs() and cabsf() implementations, to calculate distance, temporarily uses sqrt() instead of hypot() which is required but missing now.

In cexp() implementation Euler equation is used.

In reference to phoenix-rtos/phoenix-rtos-project#785
JIRA: RTOS-528

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: imxrt1176-nil, ia32-generic.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@gerard5 gerard5 self-assigned this Jul 21, 2023
@gerard5 gerard5 marked this pull request as ready for review July 21, 2023 13:17
agkaminski
agkaminski reviewed Jul 21, 2023
View reviewed changes
include/complex.h Outdated Show resolved Hide resolved
@gerard5 gerard5 force-pushed the gerard5/RTOS-528 branch 3 times, most recently from 02ed555 to 662ac0e Compare July 21, 2023 14:43
agkaminski
agkaminski approved these changes Jul 21, 2023
View reviewed changes
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

math/complex.c Show resolved Hide resolved
@gerard5
complex: Implement commonly used complex number functions
228d221 
Provide required complex.h function prototypes and commonly used
functions.

`cabs()` and `cabsf()` implementations, to calculate distance,
temporarily uses `sqrt()` instead of `hypot()` which is required
but missing now.

JIRA: RTOS-528
@gerard5 gerard5 merged commit 1197d36 into master Jul 24, 2023
25 checks passed
@gerard5 gerard5 deleted the gerard5/RTOS-528 branch July 24, 2023 08:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

@nalajcie nalajcie Awaiting requested review from nalajcie

Assignees

@gerard5 gerard5

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@gerard5 @agkaminski