Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

socket: Align struct sa_familty to allow safe casting between all sockaddr_* #276

Merged
merged 1 commit into from
Aug 11, 2023
Merged

socket: Align struct sa_familty to allow safe casting between all sockaddr_* #276

merged 1 commit into from
Aug 11, 2023

Conversation

agkaminski
Copy link
Member

DONE: RTOS-546

Description

Fixes phoenix-rtos/phoenix-rtos-project#781

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@agkaminski agkaminski requested a review from xvuko August 8, 2023 09:47
@agkaminski agkaminski force-pushed the agkaminski/rtos-546 branch 2 times, most recently from a532426 to 41d44ee Compare August 8, 2023 10:32
@agkaminski agkaminski force-pushed the agkaminski/rtos-546 branch 2 times, most recently from 4ede3b4 to 294c096 Compare August 8, 2023 10:54
github-actions[bot]
github-actions bot reviewed Aug 8, 2023
View reviewed changes
include/sys/socket.h Outdated Show resolved Hide resolved
xvuko
xvuko reviewed Aug 8, 2023
View reviewed changes
include/sys/socket.h Outdated Show resolved Hide resolved
xvuko
xvuko reviewed Aug 8, 2023
View reviewed changes
include/sys/socket.h Outdated Show resolved Hide resolved
@agkaminski agkaminski force-pushed the agkaminski/rtos-546 branch 2 times, most recently from 51050f6 to 4bdc61f Compare August 8, 2023 20:34
gerard5
gerard5 reviewed Aug 9, 2023
View reviewed changes
include/sys/socket.h Outdated Show resolved Hide resolved
github-actions[bot]
github-actions bot reviewed Aug 9, 2023
View reviewed changes
include/sys/socket.h Outdated Show resolved Hide resolved
@agkaminski agkaminski merged commit ec37ea9 into master Aug 11, 2023
25 checks passed
@agkaminski agkaminski deleted the agkaminski/rtos-546 branch August 11, 2023 11:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gerard5 gerard5 gerard5 left review comments

@github-actions GitHub Actions GitHub Actions left review comments

@xvuko xvuko xvuko approved these changes

@nalajcie nalajcie Awaiting requested review from nalajcie

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

struct sockaddr_storage cannot be safely cast to struct sockaddr_* due to alignment issues
3 participants
@agkaminski @gerard5 @xvuko