math: Fix sqrt losing precision for a very small values of x #279
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DONE: RTOS-548
Description
Fixes phoenix-rtos/phoenix-rtos-project#766
As it turns out, algorithm works just fine, whole problem was in this one line.
It was done to make single precision division instead of double precision to increase performance. But now it's of lower priority, as hardware accelerated implementation of sqrt is used on most targets. On targets with soft fpu it matters as little, as all float operations are low performance.
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment