Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

math: Fix sqrt losing precision for a very small values of x #279

Merged
merged 1 commit into from
Aug 10, 2023

Conversation

agkaminski
Copy link
Member

DONE: RTOS-548

Description

Fixes phoenix-rtos/phoenix-rtos-project#766

As it turns out, algorithm works just fine, whole problem was in this one line.
It was done to make single precision division instead of double precision to increase performance. But now it's of lower priority, as hardware accelerated implementation of sqrt is used on most targets. On targets with soft fpu it matters as little, as all float operations are low performance.

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (PC).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link
Contributor

@badochov badochov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agkaminski agkaminski merged commit 6cfa617 into master Aug 10, 2023
25 checks passed
@agkaminski agkaminski deleted the agkaminski/rtos-548 branch August 10, 2023 10:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

sqrt return wrong value for small arguments
2 participants