Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

string: strerror_r() implementation #280

Merged
merged 1 commit into from
Aug 11, 2023
Merged

Conversation

agkaminski
Copy link
Member

DONE: RTOS-554

Description

Fixes phoenix-rtos/phoenix-rtos-project#694

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (ia32-generic-qemu).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link
Member

@mateusz-bloch mateusz-bloch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, checked strerror_r on emu and hardware targets

Copy link
Contributor

@badochov badochov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

strerror should only have race with itself, but in current implementation there's a race between strerror and gai_strerror, I'd make err_unknownMsg a static variable inside each of this functions

string/strerror.c Outdated Show resolved Hide resolved
@badochov
Copy link
Contributor

I've never seen those failures on imxrt117 before however the code seems valid

@agkaminski
Copy link
Member Author

I've never seen those failures on imxrt117 before however the code seems valid

Random fail yet again

Copy link
Contributor

@badochov badochov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@agkaminski agkaminski merged commit bea8eb5 into master Aug 11, 2023
25 checks passed
@agkaminski agkaminski deleted the agkaminski/rtos-554 branch August 11, 2023 11:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Missing strerror_r() function implementation
4 participants