-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
string: strerror_r() implementation #280
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, checked strerror_r on emu and hardware targets
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
strerror
should only have race with itself, but in current implementation there's a race between strerror
and gai_strerror
, I'd make err_unknownMsg
a static variable inside each of this functions
DONE: RTOS-554
e5719c1
to
46d80a7
Compare
I've never seen those failures on imxrt117 before however the code seems valid |
Random fail yet again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
DONE: RTOS-554
Description
Fixes phoenix-rtos/phoenix-rtos-project#694
Motivation and Context
Types of changes
How Has This Been Tested?
Checklist:
Special treatment