Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libphoenix: fix mutexing in pthread_create #303

Merged
merged 1 commit into from
Oct 18, 2023
Merged

Conversation

adamdebek
Copy link
Contributor

RTOS-651

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: (list targets here).

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@github-actions
Copy link

github-actions bot commented Oct 18, 2023

Unit Test Results

5 734 tests  ±0   5 095 ✔️ ±0   27m 44s ⏱️ - 1m 11s
   311 suites ±0      639 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 95e4b20. ± Comparison against base commit 367c8ee.

♻️ This comment has been updated with latest results.

@adamdebek
Copy link
Contributor Author

adamdebek commented Oct 18, 2023

Copy link
Contributor

@damianloew damianloew left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When the commit solves some issue we should add the following line in the commit description:
Screenshot from 2023-10-18 12-06-48

@nalajcie
Copy link
Member

not doing code review, but please use locking instead of mutexing in commit message title :)

@badochov
Copy link
Contributor

Does it fix zedbaord target as well?

pthread/pthread.c Outdated Show resolved Hide resolved
Copy link
Member

@lukileczo lukileczo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@adamdebek adamdebek merged commit 894855f into master Oct 18, 2023
30 checks passed
@adamdebek adamdebek deleted the adamdebek/RTOS-651 branch October 18, 2023 12:13
@adamdebek
Copy link
Contributor Author

Does it fix zedbaord target as well?

I didn't see it fail on this target, maybe scheduling differs, but if it was failing on zedboard tihs pr should also fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants