Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

assert: use abort() instead of exit() #307

Merged
merged 1 commit into from
Nov 3, 2023
Merged

assert: use abort() instead of exit() #307

merged 1 commit into from
Nov 3, 2023

Conversation

nalajcie
Copy link
Member

@nalajcie nalajcie commented Nov 3, 2023

Motivation and Context

  • atexit functions should not be called
  • stream synchronization is optional (might lead to deadlocks)
  • the exit code should indicate the program was killed with SIGABRT

JIRA: RTOS-668

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

  • Already covered by automatic testing.
  • New test added: (add PR link here).
  • Tested by hand on: imx6ull

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

@nalajcie
assert: use abort() instead of exit()
417f7c3 
- atexit functions should not be called
- stream synchronization is optional (might lead to deadlocks)
- the exit code should indicate the program was killed with SIGABRT

JIRA: RTOS-668
@github-actions GitHub Actions
Copy link

github-actions bot commented Nov 3, 2023

Unit Test Results

5 949 tests  +215   5 296 ✔️ +201   30m 10s ⏱️ + 2m 55s
   325 suites +  14      653 💤 +  14 
       1 files   ±    0          0 ❌ ±    0 

Results for commit 417f7c3. ± Comparison against base commit 894855f.

@nalajcie nalajcie merged commit 8e3bfcd into master Nov 3, 2023
30 checks passed
@nalajcie nalajcie deleted the nalajcie/abort branch November 3, 2023 12:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@agkaminski agkaminski agkaminski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@nalajcie @agkaminski