Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pthread: implement cleanup_push/_pop #309

Merged
merged 1 commit into from
Nov 7, 2023
Merged

Conversation

lukileczo
Copy link
Member

fixes phoenix-rtos/phoenix-rtos-project#827

DONE: RTOS-671

Description

Motivation and Context

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

How Has This Been Tested?

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have added tests to cover my changes.
  • All new and existing linter checks and tests passed.
  • My changes generate no new compilation warnings for any of the targets.

Special treatment

  • This PR needs additional PRs to work (list the PRs, preferably in merge-order).
  • I will merge this PR by myself when appropriate.

Copy link

github-actions bot commented Nov 7, 2023

Unit Test Results

5 949 tests  ±0   5 296 ✔️ ±0   28m 59s ⏱️ -52s
   325 suites ±0      653 💤 ±0 
       1 files   ±0          0 ±0 

Results for commit 4f9a7b4. ± Comparison against base commit 44458bf.

♻️ This comment has been updated with latest results.

pthread/pthread.c Outdated Show resolved Hide resolved
pthread/pthread.c Outdated Show resolved Hide resolved
pthread/pthread.c Outdated Show resolved Hide resolved
pthread/pthread.c Show resolved Hide resolved
Copy link
Member

@agkaminski agkaminski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lukileczo lukileczo merged commit ef18b0b into master Nov 7, 2023
30 checks passed
@lukileczo lukileczo deleted the lukileczo/pthread-cleanup branch November 7, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Lack of pthread_cleanup_push() and pthread_cleanup_pop()
2 participants